Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix panic when create table patition by range columns #7379

Merged
merged 2 commits into from Aug 13, 2018
Merged

ddl: fix panic when create table patition by range columns #7379

merged 2 commits into from Aug 13, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Aug 13, 2018

What problem does this PR solve?

fix #7362 , ref #7366

What is changed and how it works?

Check List

Tests

  • Unit test

zimulala
zimulala reviewed Aug 13, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2018
lysu
lysu reviewed Aug 13, 2018
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2018
jackysp
jackysp approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 13, 2018
@jackysp
Copy link
Member

jackysp commented Aug 13, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@shenli shenli merged commit 71252f7 into pingcap:release-2.0 Aug 13, 2018
@winkyao winkyao deleted the fix_panic_cherry-pick branch August 14, 2018 03:14
@tiancaiamao tiancaiamao mentioned this pull request Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@zimulala zimulala zimulala left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@winkyao @jackysp @lysu @zimulala @shenli